This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronmarkham
approved these changes
May 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a style comment in there...
@mxnet-label-bot add [Doc] |
larroy
force-pushed
the
autograd_doc
branch
2 times, most recently
from
June 5, 2019 18:29
1b86fc1
to
fd9635d
Compare
@mxnet-label-bot add [pr-awaiting-merge] |
kshitij12345
reviewed
Jun 5, 2019
@szha @apeforest can we merge this PR? |
Can you address @kshitij12345 's question? |
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
apeforest
reviewed
Jun 13, 2019
Thanks for the contribution. I added some comments regarding the example. |
Fixes: |
@apeforest @kshitij12345 can this go? |
apeforest
reviewed
Jul 1, 2019
@larroy Gentle ping! |
kshitij12345
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
apeforest
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* refine autograd docs * CR comments * Fix examples * CR comments * Followup CR * CR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refines autograd docs, add second order gradient documentation.
@aaronmarkham @apeforest
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.